[all-commits] [llvm/llvm-project] 06f3b0: Revert "[SLP]Improve costs in computeExtractCost()...
Hans via All-commits
all-commits at lists.llvm.org
Fri Sep 29 01:42:50 PDT 2023
Branch: refs/heads/main
Home: https://github.com/llvm/llvm-project
Commit: 06f3b0ed436b49caf667b19c95da51b9b9fb1b75
https://github.com/llvm/llvm-project/commit/06f3b0ed436b49caf667b19c95da51b9b9fb1b75
Author: Hans Wennborg <hans at chromium.org>
Date: 2023-09-29 (Fri, 29 Sep 2023)
Changed paths:
M llvm/lib/Transforms/Vectorize/SLPVectorizer.cpp
M llvm/test/Transforms/SLPVectorizer/AMDGPU/add_sub_sat-inseltpoison.ll
M llvm/test/Transforms/SLPVectorizer/AMDGPU/add_sub_sat.ll
M llvm/test/Transforms/SLPVectorizer/AMDGPU/crash_extract_subvector_cost.ll
M llvm/test/Transforms/SLPVectorizer/AMDGPU/phi-result-use-order.ll
M llvm/test/Transforms/SLPVectorizer/RISCV/math-function.ll
M llvm/test/Transforms/SLPVectorizer/X86/alternate-calls-inseltpoison.ll
M llvm/test/Transforms/SLPVectorizer/X86/alternate-calls.ll
M llvm/test/Transforms/SLPVectorizer/X86/crash_clear_undefs.ll
M llvm/test/Transforms/SLPVectorizer/X86/hadd-inseltpoison.ll
M llvm/test/Transforms/SLPVectorizer/X86/hadd.ll
M llvm/test/Transforms/SLPVectorizer/X86/hsub-inseltpoison.ll
M llvm/test/Transforms/SLPVectorizer/X86/hsub.ll
M llvm/test/Transforms/SLPVectorizer/X86/reduction-transpose.ll
Log Message:
-----------
Revert "[SLP]Improve costs in computeExtractCost() to avoid crash after D158449."
This caused asserts:
Assertion failed: NumElts > 1 && "Expected at least 2-element fixed length vector(s).",
file C:\b\s\w\ir\cache\builder\src\third_party\llvm\llvm\lib\Transforms\Vectorize\SLPVectorizer.cpp, line 7096
see comment on https://github.com/llvm/llvm-project/commit/59a67ea35d608480257fc64ec3e5106ef50de740
> Need to consider the length of the original vector for extractelements,
> not the length, matched number of the scalars. It fixes 2 issues: 1)
> improves cost estimation; 2) Fixes crashes after D158449.
This reverts commit 59a67ea35d608480257fc64ec3e5106ef50de740.
More information about the All-commits
mailing list