[all-commits] [llvm/llvm-project] 3429aa: [BOLT] Report JITLink errors appropriately (#67633)

[Rafael Auler via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 3429aa3e60b982592e29c941b73827f3c794a401
      https://github.com/llvm/llvm-project/commit/3429aa3e60b982592e29c941b73827f3c794a401
  Author: Rafael Auler <rafaelauler at fb.com>
  Date:   2023-09-28 (Thu, 28 Sep 2023)

  Changed paths:
    M bolt/lib/Rewrite/ExecutableFileMemoryManager.cpp

  Log Message:
  -----------
  [BOLT] Report JITLink errors appropriately (#67633)

Previously we would crash with an assertion failure (unreachable code)
whenever we had an error in JITLink. Change this to use JITLink API
correctly and let it print the error to output, so we can read and more
easily diagnose what's happening.

Before this patch:
unexpected abandoned allocation
UNREACHABLE executed at...

After this patch:
BOLT-ERROR: JITLink failed: In graph in-memory object file, section
.local.foo: relocation target .text + 0x1 at address 0xa7c00000 is out
of range of BranchPCRel32 fixup at 0x132d40f1 (bar, 0x132d40f0 + 0x1)