[all-commits] [llvm/llvm-project] 974490: [NFC] [C++20] [Modules] Refactor Module::getGlobal...

Chuanqi Xu via All-commits all-commits at lists.llvm.org
Wed Sep 27 23:07:09 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 9744909a126ead515c433097c0b5f76c98e9a5b4
      https://github.com/llvm/llvm-project/commit/9744909a126ead515c433097c0b5f76c98e9a5b4
  Author: Chuanqi Xu <yedeng.yd at linux.alibaba.com>
  Date:   2023-09-28 (Thu, 28 Sep 2023)

  Changed paths:
    M clang/include/clang/Basic/Module.h
    M clang/lib/Basic/Module.cpp
    M clang/lib/CodeGen/CodeGenModule.cpp

  Log Message:
  -----------
  [NFC] [C++20] [Modules] Refactor Module::getGlobalModuleFragment and Module::getPrivateModuleFragment

The original implementation of `Module::getGlobalModuleFragment` and
`Module::getPrivateModuleFragment` tried to find the global module
fragment and the private module fragment by comparing strings, which
smells bad. This patch tries to improve this.




More information about the All-commits mailing list