[all-commits] [llvm/llvm-project] 977289: [clang][dataflow] Remove buggy assertion. (#67311)

[martinboehme via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 977289e44e3c59f96f46109351a5db463305e7c5
      https://github.com/llvm/llvm-project/commit/977289e44e3c59f96f46109351a5db463305e7c5
  Author: martinboehme <mboehme at google.com>
  Date:   2023-09-27 (Wed, 27 Sep 2023)

  Changed paths:
    M clang/lib/Analysis/FlowSensitive/Transfer.cpp

  Log Message:
  -----------
  [clang][dataflow] Remove buggy assertion. (#67311)

The assertion fails on the test
TransferTest.EvaluateBlockWithUnreachablePreds
(which I think, ironically, was introuced in the same patch as the
assertion).

This just wasn't obvious because the assertion is inside an `LLVM_DEBUG`
block
and is thus only executed if the command-line flag `-debug` is passed.
We don't
have any CI builds that do this, so it's almost guaranteed that
assertions like
this will start failing over time (if they ever passed in the first
place --
which I'm not sure about here).

It's not clear to me whether there's _some_ assertion we might be able
to make
here -- I've looked at this for a while but haven't been able to come up
with
anything obvious. For the time being, I think it's best to simply delete
the
assertion.