[all-commits] [llvm/llvm-project] 32e10a: [DebugInfo] Change return type of DWARFDebugAbbrev...

[Alex Langford via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 32e10aa65c680087c1c9cad2aaeb4526deabe235
      https://github.com/llvm/llvm-project/commit/32e10aa65c680087c1c9cad2aaeb4526deabe235
  Author: Alex Langford <alangford at apple.com>
  Date:   2023-09-26 (Tue, 26 Sep 2023)

  Changed paths:
    M llvm/include/llvm/DebugInfo/DWARF/DWARFDebugAbbrev.h
    M llvm/lib/DebugInfo/DWARF/DWARFDebugAbbrev.cpp
    M llvm/tools/obj2yaml/dwarf2yaml.cpp
    M llvm/tools/obj2yaml/macho2yaml.cpp
    M llvm/tools/obj2yaml/obj2yaml.h
    M llvm/unittests/DebugInfo/DWARF/DWARFDebugAbbrevTest.cpp

  Log Message:
  -----------
  [DebugInfo] Change return type of DWARFDebugAbbrev::parse (#67191)

To make DWARFDebugAbbrev more amenable to error-handling, I would like
to change the return type of DWARFDebugAbbrev::parse from `void` to
`Error`. Users of DWARFDebugAbbrev can consume the error if they want to
use all the valid DWARF that was parsed (without worrying about the
malformed DWARF) or stop when the parse fails if the use case needs to
be strict.

This also will bring the LLVM DWARFDebugAbbrev interface closer to
LLDB's which opens up the opportunity for LLDB adopt the LLVM
implementation with minimal changes.