[all-commits] [llvm/llvm-project] c50617: Simplify diagnostic error management for MLIR prop...

[Mehdi Amini via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: c50617dae3d3e1d324d31c3071965076a1856b4d
      https://github.com/llvm/llvm-project/commit/c50617dae3d3e1d324d31c3071965076a1856b4d
  Author: Mehdi Amini <joker.eph at gmail.com>
  Date:   2023-09-26 (Tue, 26 Sep 2023)

  Changed paths:
    M mlir/include/mlir/IR/ExtensibleDialect.h
    M mlir/include/mlir/IR/ODSSupport.h
    M mlir/include/mlir/IR/OpDefinition.h
    M mlir/include/mlir/IR/Operation.h
    M mlir/include/mlir/IR/OperationSupport.h
    M mlir/lib/AsmParser/Parser.cpp
    M mlir/lib/CAPI/IR/IR.cpp
    M mlir/lib/IR/MLIRContext.cpp
    M mlir/lib/IR/ODSSupport.cpp
    M mlir/lib/IR/Operation.cpp
    M mlir/lib/IR/OperationSupport.cpp
    M mlir/lib/TableGen/CodeGenHelpers.cpp
    M mlir/test/lib/Dialect/Test/TestDialect.cpp
    M mlir/test/lib/Dialect/Test/TestDialect.h
    M mlir/test/mlir-tblgen/constraint-unique.td
    M mlir/test/mlir-tblgen/interfaces-as-constraints.td
    M mlir/tools/mlir-tblgen/OpDefinitionsGen.cpp
    M mlir/unittests/IR/OpPropertiesTest.cpp

  Log Message:
  -----------
  Simplify diagnostic error management for MLIR properties API (NFC) (#67409)

This is a follow-up to 8c2bff1ab929 which lazy-initialized the
diagnostic and removed the need to dynamically abandon() an
InFlightDiagnostic. This further simplifies the code to not needed to
return a reference to an InFlightDiagnostic and instead eagerly emit
errors.

Also use `emitError` as name instead of `getDiag` which seems more
explicit and in-line with the common usage.