[all-commits] [llvm/llvm-project] 78d649: [libc++][lit] Allow overriding the executor for te...

[Alexander Richardson via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 78d649a417b48cb8a2ba2e755f0e7c8fb8b1bb83
      https://github.com/llvm/llvm-project/commit/78d649a417b48cb8a2ba2e755f0e7c8fb8b1bb83
  Author: Alexander Richardson <alexrichardson at google.com>
  Date:   2023-09-26 (Tue, 26 Sep 2023)

  Changed paths:
    M clang/cmake/caches/CrossWinToARMLinux.cmake
    M libcxx/docs/ReleaseNotes/18.rst
    M libcxx/test/CMakeLists.txt
    M libcxx/test/configs/cmake-bridge.cfg.in
    M libcxx/utils/libcxx/test/params.py
    M libcxxabi/test/CMakeLists.txt
    M libcxxabi/test/configs/cmake-bridge.cfg.in
    M libunwind/test/CMakeLists.txt
    M libunwind/test/configs/cmake-bridge.cfg.in

  Log Message:
  -----------
  [libc++][lit] Allow overriding the executor for tests (#66545)

This is useful when trying to run multiple tests with different
arguments to the executor script. This is needed in my case since I
do not know the correct ssh connection arguments when building libc++.
The testing script I have spawns multiple QEMU instances that listen on
a given port on localhost and runs lit with the --num-shards/--run-shard
argument. In order to connect each shard to the right QEMU instances I
need to customize the arguments passed to ssh.py (--extra-ssh-args and
--extra-scp-args) but can't do this at configure time since the target
port is only known when running the tests but not when calling CMake.
This change allows me to pass `executor=ssh.py <args>` to lit once I
know
the right hostname/port for running the tests.

This also deprecates the `LIB{CXX,CXXABI,UNWIND}_EXECUTOR` CMake
variable
as the same can be achieved by adding `executor=...` to the
`LIB{CXX,CXXABI,UNWIND}_TEST_PARAMS` variable.