[all-commits] [llvm/llvm-project] 9971ae: [Flang][OpenMP][Driver][Test] Fix the omp-driver-o...

[agozillon via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 9971aefff8b947896ba8b497880bcb09a625d25f
      https://github.com/llvm/llvm-project/commit/9971aefff8b947896ba8b497880bcb09a625d25f
  Author: agozillon <Andrew.Gozillon at amd.com>
  Date:   2023-09-26 (Tue, 26 Sep 2023)

  Changed paths:
    M flang/test/Driver/omp-driver-offload.f90

  Log Message:
  -----------
  [Flang][OpenMP][Driver][Test] Fix the omp-driver-offload-test commands (#66926)

Since the changes to -### to correctly return error codes in D156363,
some additions of the not lit keyword and perhaps some changes to how
fopenmp-targets is handled; the test omp-driver-offload.f90 has become a
little susceptible to what appears to be sporadic failures.

This was because if certain environment variables are set for AMD
devices some of the commands succeed happily and the not check causes
the test to fail. Whereas, if they were not set the tests would fail and
the not test would succeed, allowing the test to pass provided you were
not targeting AMD hardware while running the test.

When the environment variables for AMD hardware are set the compiler
could find the correct offload architecture to compile for, allowing the
command to succeed. However, when not set it'd fail as it can't detect
the offload architecture. The solution to this is to specify an AMD
architecture via --offload-arch so it always passes, the architecture
doesn't really matter, I've chosen to select gfx90a.