[all-commits] [llvm/llvm-project] 55ec9d: [lldb][NFCI] Change parameter type in UserExpressi...

[Alex Langford via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 55ec9db42ae03661d1a2913423f56b58db581199
      https://github.com/llvm/llvm-project/commit/55ec9db42ae03661d1a2913423f56b58db581199
  Author: Alex Langford <alangford at apple.com>
  Date:   2023-09-22 (Fri, 22 Sep 2023)

  Changed paths:
    M lldb/include/lldb/Expression/UserExpression.h
    M lldb/source/Expression/UserExpression.cpp
    M lldb/source/Plugins/ExpressionParser/Clang/ClangUserExpression.cpp
    M lldb/source/Plugins/ExpressionParser/Clang/ClangUserExpression.h

  Log Message:
  -----------
  [lldb][NFCI] Change parameter type in UserExpression::GetObjectPointer (#67055)

GetObjectPointer (and other related methods) do not need `ConstString`
parameters. The string parameter in these methods boil down to getting a
StringRef and calling `StackFrame::GetValueForVariableExpressionPath`
which takes a `StringRef` parameter. All the users of `GetObjectPointer`
(and related methods) end up creating ConstString objects to pass to
these methods, but they could just as easily be StringRefs (potentially
saving us some allocations in the StringPool).