[all-commits] [llvm/llvm-project] bb01fd: [lldb] Require paused process and frame for "regis...

[David Spickett via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: bb01fd57bcaec533cd08b4d107979511d893f5b3
      https://github.com/llvm/llvm-project/commit/bb01fd57bcaec533cd08b4d107979511d893f5b3
  Author: David Spickett <david.spickett at linaro.org>
  Date:   2023-09-22 (Fri, 22 Sep 2023)

  Changed paths:
    M lldb/source/Commands/CommandObjectRegister.cpp
    M lldb/test/API/commands/register/register/register_command/TestRegisters.py

  Log Message:
  -----------
  [lldb] Require paused process and frame for "register info" command (#67124)

Prior to this the command would simply crash when run on a running
process.

Of the three register commands, "info" was the only one missing these
requirements. On some level it makes sense because you're not going to
read a value or modify anything, but practically I think lldb assumes
any time you're going to access register related stuff, the process
should be paused.

I noticed this debugging with a remote gdb stub, so I've recreated that
scenario using attach in a new test case.