[all-commits] [llvm/llvm-project] 6ebc17: [AMDGPU][MC][GFX11] Always output wait_vdst and wa...

Carl Ritson via All-commits all-commits at lists.llvm.org
Thu Sep 21 17:25:15 PDT 2023

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 6ebc1799788f3bb12a531007917986d95a79714c
  Author: Carl Ritson <carl.ritson at amd.com>
  Date:   2023-09-22 (Fri, 22 Sep 2023)

  Changed paths:
    M llvm/lib/Target/AMDGPU/MCTargetDesc/AMDGPUInstPrinter.cpp
    M llvm/test/MC/AMDGPU/gfx11_asm_ldsdir.s
    M llvm/test/MC/AMDGPU/gfx11_asm_vinterp.s
    M llvm/test/MC/Disassembler/AMDGPU/gfx11_dasm_ldsdir.txt
    M llvm/test/MC/Disassembler/AMDGPU/gfx11_dasm_vinterp.txt

  Log Message:
  [AMDGPU][MC][GFX11] Always output wait_vdst and wait_exp (#66610)

Always output values of wait_vdst and wait_exp in assembly even when
they are zero.

While we normally avoid outputing default/zero parameters in assembly,
the values of these parameters still imply wait behaviour when zero.
Outputing zero values makes the intent more obvious to human readers,
and avoid any future ambiguity if we choose to change the defaults to
something other than zero.

Fixes #66383

More information about the All-commits mailing list