[all-commits] [llvm/llvm-project] 35e393: watch set expression's default type was wrong with...

Jason Molenda via All-commits all-commits at lists.llvm.org
Thu Sep 21 14:50:52 PDT 2023

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 35e3939cb06d19942a30fd39f1416f49a7b982a4
  Author: Jason Molenda <jmolenda at apple.com>
  Date:   2023-09-21 (Thu, 21 Sep 2023)

  Changed paths:
    M lldb/source/Commands/CommandObjectWatchpoint.cpp
    M lldb/test/API/commands/watchpoints/watch_tagged_addr/TestWatchTaggedAddress.py

  Log Message:
  watch set expression's default type was wrong with new modify type

`watch set expression` was passing the OptionGroupWatchpoint enum
in to Target where the LLDB_WATCH_TYPE_* bitfield was expected.
Modify matched READ|WRITE and resulted in a test failure in
TestWatchTaggedAddress.py.  David temporarily changed the test to
expect this incorrect output; this fixes the bug and updates the
test case to test it for correctness again.

More information about the All-commits mailing list