[all-commits] [llvm/llvm-project] 8fb28e: [BOLT] Fix data race in MCPlusBuilder::getOrCreate...

[Kristof Beyls via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 8fb28e45ce043eb8869da139cf58ac2602d3bafa
      https://github.com/llvm/llvm-project/commit/8fb28e45ce043eb8869da139cf58ac2602d3bafa
  Author: Kristof Beyls <kristof.beyls at arm.com>
  Date:   2023-09-21 (Thu, 21 Sep 2023)

  Changed paths:
    M bolt/include/bolt/Core/MCPlusBuilder.h

  Log Message:
  -----------
  [BOLT] Fix data race in MCPlusBuilder::getOrCreateAnnotationIndex (#67004)

MCPlusBuilder::getOrCreateAnnotationIndex(Name) can be called from
different threads, for example when making use of
ParallelUtilities::runOnEachFunctionWithUniqueAllocId.

The race occurs when an Index for a particular annotation Name needs to
be created for the first time.

For example, this can easily happen when multiple "copies" of an
analysis pass run on different BinaryFunctions, and the analysis pass
creates a new Annotation Index to be able to store analysis results as
annotations.

This was found by using the ThreadSanitizer.

No regression test was added; I don't think there is good way to write
regression tests that verify the absence of data races?

---------

Co-authored-by: Amir Ayupov <fads93 at gmail.com>