[all-commits] [llvm/llvm-project] 6b4a1f: [NFC][AsmPrinter] Refactor constructVariableDIE (#...

Scott Linder via All-commits all-commits at lists.llvm.org
Thu Sep 21 08:24:13 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 6b4a1f23206f7abb2330ddfc3cbdc6f210debce8
      https://github.com/llvm/llvm-project/commit/6b4a1f23206f7abb2330ddfc3cbdc6f210debce8
  Author: Scott Linder <72270781+slinder1 at users.noreply.github.com>
  Date:   2023-09-21 (Thu, 21 Sep 2023)

  Changed paths:
    M llvm/lib/CodeGen/AsmPrinter/DwarfCompileUnit.cpp
    M llvm/lib/CodeGen/AsmPrinter/DwarfCompileUnit.h

  Log Message:
  -----------
  [NFC][AsmPrinter] Refactor constructVariableDIE (#66435)

Fold constructVariableDIEImpl into constructVariableDIE, simplify it and
group related functions.

Pull out the previously inline lambdas for visiting the active variant
of the DbgVariable to add location and related attributes as an overload
set for a private method
applyConcreteDbgVariableAttributes.

Rename applyVariableAttribute to reflect what kinds of attributes it
applies, and to contrast it with the new
applyConcreteDbgVariableAttributes.

Move constructLabelDIE down in the implementation file, so all of the
constructVariableDIE-related function impls are adjacent.




More information about the All-commits mailing list