[all-commits] [llvm/llvm-project] 7e7444: Reland "[lldb][AArch64] Linux corefile support for...

David Spickett via All-commits all-commits at lists.llvm.org
Thu Sep 21 06:55:49 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 7e744460e7ef0c3c54191b4cd0d7e9749d6fc16c
      https://github.com/llvm/llvm-project/commit/7e744460e7ef0c3c54191b4cd0d7e9749d6fc16c
  Author: David Spickett <david.spickett at linaro.org>
  Date:   2023-09-21 (Thu, 21 Sep 2023)

  Changed paths:
    M lldb/source/Plugins/Process/Utility/RegisterContextPOSIX_arm64.h
    M lldb/source/Plugins/Process/elf-core/RegisterContextPOSIXCore_arm64.cpp
    M lldb/source/Plugins/Process/elf-core/RegisterContextPOSIXCore_arm64.h
    M lldb/source/Plugins/Process/elf-core/RegisterUtilities.h
    A lldb/test/API/linux/aarch64/sme_core_file/TestAArch64LinuxSMECoreFile.py
    A lldb/test/API/linux/aarch64/sme_core_file/core_0_16_32_1
    A lldb/test/API/linux/aarch64/sme_core_file/core_0_32_16_0
    A lldb/test/API/linux/aarch64/sme_core_file/core_1_16_32_0
    A lldb/test/API/linux/aarch64/sme_core_file/core_1_32_16_1
    A lldb/test/API/linux/aarch64/sme_core_file/main.c

  Log Message:
  -----------
  Reland "[lldb][AArch64] Linux corefile support for SME"

This reverts commit 3fa503582315f23f187a019f026c5fce59b3f3d8.

m_sve_state was not initialised which (I'm guessing) meant that
it could potentially be a value that matched a real SVE state.
Then we'd be acting as if we're streaming mode, for example,
without ever having the data required to back that up.

By sheer luck this only turn up on x86, AArch64 and ARM were fine.
It is UB regardless.




More information about the All-commits mailing list