[all-commits] [llvm/llvm-project] 75e862: Reland "[lldb] Add 'modify' type watchpoints, make...

[David Spickett via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 75e862077834c06e574d34e8958dd2ee7cc1d334
      https://github.com/llvm/llvm-project/commit/75e862077834c06e574d34e8958dd2ee7cc1d334
  Author: David Spickett <david.spickett at linaro.org>
  Date:   2023-09-21 (Thu, 21 Sep 2023)

  Changed paths:
    M lldb/bindings/headers.swig
    A lldb/bindings/interface/SBWatchpointOptionsDocstrings.i
    M lldb/bindings/interfaces.swig
    M lldb/include/lldb/API/SBTarget.h
    A lldb/include/lldb/API/SBWatchpointOptions.h
    M lldb/include/lldb/Breakpoint/Watchpoint.h
    M lldb/include/lldb/Interpreter/OptionGroupWatchpoint.h
    M lldb/include/lldb/lldb-defines.h
    M lldb/include/lldb/lldb-enumerations.h
    M lldb/include/lldb/lldb-forward.h
    M lldb/source/API/CMakeLists.txt
    M lldb/source/API/SBTarget.cpp
    M lldb/source/API/SBValue.cpp
    M lldb/source/API/SBWatchpoint.cpp
    A lldb/source/API/SBWatchpointOptions.cpp
    M lldb/source/Breakpoint/Watchpoint.cpp
    M lldb/source/Commands/CommandObjectWatchpoint.cpp
    M lldb/source/Interpreter/OptionGroupWatchpoint.cpp
    M lldb/source/Plugins/Process/gdb-remote/ProcessGDBRemote.cpp
    M lldb/source/Target/StopInfo.cpp
    M lldb/source/Target/Target.cpp
    M lldb/test/API/commands/watchpoints/multiple_hits/main.cpp
    M lldb/test/API/commands/watchpoints/step_over_watchpoint/TestStepOverWatchpoint.py
    M lldb/test/API/commands/watchpoints/step_over_watchpoint/main.c
    M lldb/test/API/commands/watchpoints/unaligned-watchpoint/main.c
    M lldb/test/API/commands/watchpoints/watch_tagged_addr/TestWatchTaggedAddress.py
    M lldb/test/API/functionalities/gdb_remote_client/TestNoWatchpointSupportInfo.py
    M lldb/test/API/functionalities/watchpoint/large-watchpoint/TestLargeWatchpoint.py
    A lldb/test/API/functionalities/watchpoint/modify-watchpoints/Makefile
    A lldb/test/API/functionalities/watchpoint/modify-watchpoints/TestModifyWatchpoint.py
    A lldb/test/API/functionalities/watchpoint/modify-watchpoints/main.c
    M lldb/test/API/functionalities/watchpoint/unaligned-spanning-two-dwords/TestUnalignedSpanningDwords.py
    M lldb/test/API/python_api/default-constructor/sb_target.py
    M lldb/test/API/python_api/watchpoint/watchlocation/TestTargetWatchAddress.py

  Log Message:
  -----------
  Reland "[lldb] Add 'modify' type watchpoints, make it default (#66308)"

This reverts commit a7b78cac9a77e3ef6bbbd8ab1a559891dc693401.

With updates to the tests.

TestWatchTaggedAddress.py: Updated the expected watchpoint types,
though I'm not sure there should be a differnt default for the two
ways of setting them, that needs to be confirmed.

TestStepOverWatchpoint.py: Skipped this everywhere because I think
what used to happen is you couldn't put 2 watchpoints on the same
address (after alignment). I guess that this is now allowed because
modify watchpoints aren't accounted for, but likely should be.
Needs investigating.