[all-commits] [llvm/llvm-project] 6bad17: [SPIRV][DX] Share one test between backends (#65975)

Nathan Gauër via All-commits all-commits at lists.llvm.org
Thu Sep 21 03:16:08 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 6bad175a872d9443b07069cd67c4682af594deb0
      https://github.com/llvm/llvm-project/commit/6bad175a872d9443b07069cd67c4682af594deb0
  Author: Nathan Gauër <brioche at google.com>
  Date:   2023-09-21 (Thu, 21 Sep 2023)

  Changed paths:
    R llvm/test/CodeGen/DirectX/empty_cs_entry.ll
    A llvm/test/Frontend/HLSL/empty_cs_entry.ll
    A llvm/test/Frontend/HLSL/lit.local.cfg

  Log Message:
  -----------
  [SPIRV][DX] Share one test between backends (#65975)

One big issue with DirectXShaderCompiler was test coverage: DXIL and
SPIR-V backends had their own tests. When a bug was found in one, the
other wasn't always checked. This lead to unequal support of HLSL for
both backends. We'd like to avoid those issues here, hence the
test-sharing.

By default, all the tests in this folder are marked as requiring
DirectX. But as SPIR-V support grows, each test drop this requirement,
and check the SPIR-V behavior.

I would have preferred to mark new tests as XFAIL for SPIR-V by default,
so we could differentiate real unsupported tests (as SPIR-V has no
equivalent), from newly added tests. But the way LIT is built, I don't
think this is possible.

---------

Signed-off-by: Nathan Gauër <brioche at google.com>




More information about the All-commits mailing list