[all-commits] [llvm/llvm-project] 434907: [NFC][AsmPrinter] Refactor FrameIndexExprs as a st...

Scott Linder via All-commits all-commits at lists.llvm.org
Wed Sep 20 09:05:18 PDT 2023

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 434907e474a823ee4d96ca0aa4f30992fb03a3b8
  Author: Scott Linder <72270781+slinder1 at users.noreply.github.com>
  Date:   2023-09-20 (Wed, 20 Sep 2023)

  Changed paths:
    M llvm/lib/CodeGen/AsmPrinter/DwarfDebug.cpp
    M llvm/lib/CodeGen/AsmPrinter/DwarfDebug.h

  Log Message:
  [NFC][AsmPrinter] Refactor FrameIndexExprs as a std::set (#66433)

This avoids the need for a mutable member to implement deferred sorting,
and some bespoke code to maintain a SmallVector as a set.

The performance impact seems to be negligible in some small tests, and
so seems acceptable to greatly simplify the code.

An old FIXME and accompanying workaround are dropped. It is ostensibly
dead-code within the current codebase.

More information about the All-commits mailing list