[all-commits] [llvm/llvm-project] 1b8b55: [mlir][Vector] Add fastmath flags to vector.reduct...

Nicolas Vasilache via All-commits all-commits at lists.llvm.org
Wed Sep 20 07:57:35 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 1b8b55644313216e6b0fa233bbd8b01fee23f99f
      https://github.com/llvm/llvm-project/commit/1b8b55644313216e6b0fa233bbd8b01fee23f99f
  Author: Nicolas Vasilache <nicolasvasilache at users.noreply.github.com>
  Date:   2023-09-20 (Wed, 20 Sep 2023)

  Changed paths:
    M mlir/include/mlir/Dialect/LLVMIR/LLVMIntrinsicOps.td
    M mlir/include/mlir/Dialect/Vector/IR/CMakeLists.txt
    A mlir/include/mlir/Dialect/Vector/IR/Vector.td
    A mlir/include/mlir/Dialect/Vector/IR/VectorAttributes.td
    M mlir/include/mlir/Dialect/Vector/IR/VectorOps.h
    M mlir/include/mlir/Dialect/Vector/IR/VectorOps.td
    M mlir/lib/Conversion/VectorToLLVM/ConvertVectorToLLVM.cpp
    M mlir/lib/Dialect/Vector/IR/CMakeLists.txt
    M mlir/lib/Dialect/Vector/IR/VectorOps.cpp
    A mlir/python/mlir/dialects/Vector.td
    M mlir/test/Conversion/VectorToLLVM/vector-reduction-to-llvm.mlir
    M mlir/test/Conversion/VectorToLLVM/vector-to-llvm.mlir
    M mlir/test/Dialect/Vector/ops.mlir
    M mlir/test/Target/LLVMIR/Import/intrinsic.ll
    M mlir/test/Target/LLVMIR/llvmir-intrinsics.mlir

  Log Message:
  -----------
  [mlir][Vector] Add fastmath flags to vector.reduction (#66905)

This revision pipes the fastmath attribute support through the
vector.reduction op. This seemingly simple first step already requires
quite some genuflexions, file and builder reorganization. In the
process, retire the boolean reassoc flag deep in the LLVM dialect
builders and just use the fastmath attribute.

During conversions, templated builders for predicated intrinsics are
partially cleaned up. In the future, to finalize the cleanups, one
should consider adding fastmath to the VPIntrinsic ops.




More information about the All-commits mailing list