[all-commits] [llvm/llvm-project] 96b178: [lldb-vscode] Use auto summaries whenever variable...

[Walter Erquinigo via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 96b1784ac8c52fb912150de1387117de62de13ad
      https://github.com/llvm/llvm-project/commit/96b1784ac8c52fb912150de1387117de62de13ad
  Author: Walter Erquinigo <a20012251 at gmail.com>
  Date:   2023-09-20 (Wed, 20 Sep 2023)

  Changed paths:
    M lldb/test/API/tools/lldb-vscode/evaluate/TestVSCode_evaluate.py
    M lldb/test/API/tools/lldb-vscode/evaluate/main.cpp
    M lldb/tools/lldb-vscode/JSONUtils.cpp

  Log Message:
  -----------
  [lldb-vscode] Use auto summaries whenever variables don't have a summary (#66551)

Auto summaries were only being used when non-pointer/reference variables
didn't have values nor summaries. Greg pointed out that it should be
better to simply use auto summaries when the variable doesn't have a
summary of its own, regardless of other conditions.

This led to code simplification and correct visualization of auto
summaries for pointer/reference types, as seen in this screenshot.

<img width="310" alt="Screenshot 2023-09-19 at 7 04 55 PM"
src="https://github.com/llvm/llvm-project/assets/1613874/d356d579-13f2-487b-ae3a-f3443dce778f">