[all-commits] [llvm/llvm-project] 7265f7: Fix a bug with cancelling "attach -w" after you ha...

jimingham via All-commits all-commits at lists.llvm.org
Tue Sep 19 11:26:06 PDT 2023

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 7265f792dc8e1157a3874aee5f8aed6d4d8236e7
  Author: jimingham <jingham at apple.com>
  Date:   2023-09-19 (Tue, 19 Sep 2023)

  Changed paths:
    M lldb/include/lldb/Interpreter/CommandInterpreter.h
    M lldb/source/Interpreter/CommandInterpreter.cpp
    M lldb/source/Target/Process.cpp
    M lldb/test/API/commands/process/attach/TestProcessAttach.py
    M lldb/test/API/commands/process/attach/main.cpp

  Log Message:
  Fix a bug with cancelling "attach -w" after you have run a process previously (#65822)

The problem is that the when the "attach" command is initiated, the
ExecutionContext for the command has a process - it's the exited one
from the previour run. But the `attach wait` creates a new process for
the attach, and then errors out instead of interrupting when it finds
that its process and the one in the command's ExecutionContext don't

This change checks that if we're returning a target from
GetExecutionContext, we fill the context with it's current process, not
some historical one.

More information about the All-commits mailing list