[all-commits] [llvm/llvm-project] 44532a: Revert "[lldb] Add 'modify' type watchpoints, make...

[Jason Molenda via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 44532a9dd4a0ed08850dbddf80b7abcc51c4a7f1
      https://github.com/llvm/llvm-project/commit/44532a9dd4a0ed08850dbddf80b7abcc51c4a7f1
  Author: Jason Molenda <jason at molenda.com>
  Date:   2023-09-18 (Mon, 18 Sep 2023)

  Changed paths:
    M lldb/bindings/headers.swig
    R lldb/bindings/interface/SBWatchpointOptionsDocstrings.i
    M lldb/bindings/interfaces.swig
    M lldb/include/lldb/API/SBTarget.h
    R lldb/include/lldb/API/SBWatchpointOptions.h
    M lldb/include/lldb/Breakpoint/Watchpoint.h
    M lldb/include/lldb/Interpreter/OptionGroupWatchpoint.h
    M lldb/include/lldb/lldb-defines.h
    M lldb/include/lldb/lldb-enumerations.h
    M lldb/include/lldb/lldb-forward.h
    M lldb/source/API/CMakeLists.txt
    M lldb/source/API/SBTarget.cpp
    M lldb/source/API/SBValue.cpp
    M lldb/source/API/SBWatchpoint.cpp
    R lldb/source/API/SBWatchpointOptions.cpp
    M lldb/source/Breakpoint/Watchpoint.cpp
    M lldb/source/Commands/CommandObjectWatchpoint.cpp
    M lldb/source/Interpreter/OptionGroupWatchpoint.cpp
    M lldb/source/Plugins/Process/gdb-remote/ProcessGDBRemote.cpp
    M lldb/source/Target/StopInfo.cpp
    M lldb/source/Target/Target.cpp
    M lldb/test/API/commands/watchpoints/multiple_hits/main.cpp
    M lldb/test/API/commands/watchpoints/unaligned-watchpoint/main.c
    M lldb/test/API/functionalities/gdb_remote_client/TestNoWatchpointSupportInfo.py
    M lldb/test/API/functionalities/watchpoint/large-watchpoint/TestLargeWatchpoint.py
    R lldb/test/API/functionalities/watchpoint/modify-watchpoints/Makefile
    R lldb/test/API/functionalities/watchpoint/modify-watchpoints/TestModifyWatchpoint.py
    R lldb/test/API/functionalities/watchpoint/modify-watchpoints/main.c
    M lldb/test/API/functionalities/watchpoint/unaligned-spanning-two-dwords/TestUnalignedSpanningDwords.py
    M lldb/test/API/python_api/default-constructor/sb_target.py
    M lldb/test/API/python_api/watchpoint/watchlocation/TestTargetWatchAddress.py

  Log Message:
  -----------
  Revert "[lldb] Add 'modify' type watchpoints, make it default (#66308)"

TestStepOverWatchpoint.py and TestUnalignedWatchpoint.py are failing
on the ubuntu and debian bots
https://lab.llvm.org/buildbot/#/builders/68/builds/60204
https://lab.llvm.org/buildbot/#/builders/96/builds/45623

and the newly added test TestModifyWatchpoint.py does not
work on windows bot
https://lab.llvm.org/buildbot/#/builders/219/builds/5708

I will debug tomorrow morning and reland.

This reverts commit 3692267ca8f9c51cb55e4387283762d921fe2ae2.