[all-commits] [llvm/llvm-project] 2dc628: [libc++]Declaring '__asign_view__' as a non noex...

Rishabh Bali via All-commits all-commits at lists.llvm.org
Fri Aug 25 09:26:41 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 2dc6281b98d07f43a64d0ef34405d9a12d59e8b6
      https://github.com/llvm/llvm-project/commit/2dc6281b98d07f43a64d0ef34405d9a12d59e8b6
  Author: Rishabh Bali <rishabhsbali at gmail.com>
  Date:   2023-08-25 (Fri, 25 Aug 2023)

  Changed paths:
    M libcxx/include/__filesystem/path.h

  Log Message:
  -----------
   [libc++]Declaring '__asign_view__'  as a non noexcept function

`__assign_view__` is declared as a noexcept function in `libcxx/include/__filesystem/path.h` however internally it calls `std::basic_string<char>::basic_string<char>(std::string_view)` which is not a noexcept function this may lead to a `std::terminate()` call when allocation of a new string fails.

Fixes : https://github.com/llvm/llvm-project/issues/64858

Reviewed By: Mordante, #libc

Differential Revision: https://reviews.llvm.org/D158826




More information about the All-commits mailing list