[all-commits] [llvm/llvm-project] 5db0d7: Finish renaming getOperandSegmentSizeAttr() from `...

Fri Aug 25 00:43:26 PDT 2023

  Branch: refs/heads/release/17.x
  Home:   https://github.com/llvm/llvm-project
  Commit: 5db0d770c7e8739a56dc8273ed2481041813153a
      https://github.com/llvm/llvm-project/commit/5db0d770c7e8739a56dc8273ed2481041813153a
  Author: Mehdi Amini <joker.eph at gmail.com>
  Date:   2023-08-25 (Fri, 25 Aug 2023)

  Changed paths:
    M flang/lib/Optimizer/Dialect/FIROps.cpp
    M flang/test/Fir/convert-to-llvm-openmp-and-fir.fir
    M flang/test/Fir/convert-to-llvm.fir
    M mlir/docs/PatternRewriter.md
    M mlir/include/mlir/Dialect/IRDL/IR/IRDLOps.td
    M mlir/include/mlir/Dialect/Linalg/IR/LinalgInterfaces.td
    M mlir/include/mlir/IR/OpBase.td
    M mlir/include/mlir/IR/OpDefinition.h
    M mlir/lib/Bindings/Python/IRCore.cpp
    M mlir/lib/Dialect/AMDGPU/Transforms/EmulateAtomics.cpp
    M mlir/lib/Dialect/Async/IR/Async.cpp
    M mlir/lib/Dialect/Linalg/IR/LinalgOps.cpp
    M mlir/lib/Dialect/SCF/IR/SCF.cpp
    M mlir/lib/Rewrite/ByteCode.cpp
    M mlir/test/Bytecode/operand_segment_sizes.mlir
    M mlir/test/Conversion/OpenMPToLLVM/convert-to-llvmir.mlir
    M mlir/test/Dialect/GPU/invalid.mlir
    M mlir/test/Dialect/LLVMIR/invalid.mlir
    M mlir/test/Dialect/Linalg/named-ops.mlir
    M mlir/test/Dialect/OpenMP/invalid.mlir
    M mlir/test/Dialect/OpenMP/ops.mlir
    M mlir/test/Dialect/PDL/invalid.mlir
    M mlir/test/Dialect/PDLInterp/invalid.mlir
    M mlir/test/Dialect/SCF/invalid.mlir
    M mlir/test/Dialect/SPIRV/IR/control-flow-ops.mlir
    M mlir/test/Dialect/Transform/ops-invalid.mlir
    M mlir/test/IR/parser.mlir
    M mlir/test/IR/traits.mlir
    M mlir/test/Rewrite/pdl-bytecode.mlir
    M mlir/test/Target/LLVMIR/omptarget-llvm.mlir
    M mlir/test/Target/LLVMIR/omptarget-region-device-llvm.mlir
    M mlir/test/Target/LLVMIR/omptarget-region-llvm.mlir
    M mlir/test/Target/LLVMIR/omptarget-region-parallel-llvm.mlir
    M mlir/test/Target/LLVMIR/openmp-llvm.mlir
    M mlir/test/Transforms/canonicalize-block-merge.mlir
    M mlir/test/Transforms/sccp.mlir
    M mlir/test/mlir-tblgen/op-decl-and-defs.td
    M mlir/test/mlir-tblgen/op-python-bindings.td
    M mlir/test/python/dialects/linalg/ops.py
    M mlir/test/python/dialects/ods_helpers.py
    M mlir/tools/mlir-tblgen/OpDefinitionsGen.cpp
    M mlir/tools/mlir-tblgen/OpFormatGen.cpp
    M mlir/tools/mlir-tblgen/OpPythonBindingGen.cpp
    M mlir/unittests/IR/AdaptorTest.cpp

  Log Message:
  -----------
  Finish renaming getOperandSegmentSizeAttr() from `operand_segment_sizes` to `operandSegmentSizes`

This renaming started with the native ODS support for properties, this is completing it.

A mass automated textual rename seems safe for most codebases.
Drop also the ods prefix to keep the accessors the same as they were before
this change:
 properties.odsOperandSegmentSizes
reverts back to:
 properties.operandSegementSizes

The ODS prefix was creating divergence between all the places and make it harder to
be consistent.

Reviewed By: jpienaar

Differential Revision: https://reviews.llvm.org/D157173

  Commit: 67dca9da75b2661d14a34067551ea71aaae19cf8
      https://github.com/llvm/llvm-project/commit/67dca9da75b2661d14a34067551ea71aaae19cf8
  Author: Mehdi Amini <joker.eph at gmail.com>
  Date:   2023-08-25 (Fri, 25 Aug 2023)

  Changed paths:
    M mlir/test/mlir-tblgen/attr-or-type-format.td
    M mlir/tools/mlir-tblgen/AttrOrTypeDefGen.cpp

  Log Message:
  -----------
  Fix MLIR build failure: error: no member named 'getValue' in 'mlir::OptionalParseResult'

Fix #63072

  Commit: 0d8fd074b7a5426541edd91774e5cee63dbe805d
      https://github.com/llvm/llvm-project/commit/0d8fd074b7a5426541edd91774e5cee63dbe805d
  Author: Mehdi Amini <joker.eph at gmail.com>
  Date:   2023-08-25 (Fri, 25 Aug 2023)

  Changed paths:
    M mlir/tools/mlir-tblgen/OpDefinitionsGen.cpp
    M mlir/tools/mlir-tblgen/OpFormatGen.cpp

  Log Message:
  -----------
  Fix some missing fully qualified namespaces in MLIR TableGen generator

Using properties would break when a dialect isn't in the mlir namespace

  Commit: c5f0c32da7778e6e712b746dac35a628c86af265
      https://github.com/llvm/llvm-project/commit/c5f0c32da7778e6e712b746dac35a628c86af265
  Author: Mehdi Amini <joker.eph at gmail.com>
  Date:   2023-08-25 (Fri, 25 Aug 2023)

  Changed paths:
    M mlir/include/mlir/Pass/PassManager.h
    M mlir/lib/Pass/Pass.cpp
    M mlir/unittests/Pass/PassManagerTest.cpp

  Log Message:
  -----------
  Fix MLIR pass manager initialization: hash the pass pipeline to detect when initialization is needed

The current logic hashes the context to detect registration changes and re-run
the pass initialization. However it wasn't checking for changes to the
pipeline, so a pass that would get added after a first run would not be
initialized during subsequent runs.

Reviewed By: Mogball

Differential Revision: https://reviews.llvm.org/D158377

  Commit: 69946c8c9ce76f3bf6fbac789ef426a468d6eb5a
      https://github.com/llvm/llvm-project/commit/69946c8c9ce76f3bf6fbac789ef426a468d6eb5a
  Author: Mehdi Amini <joker.eph at gmail.com>
  Date:   2023-08-25 (Fri, 25 Aug 2023)

  Changed paths:
    M mlir/lib/Pass/Pass.cpp

  Log Message:
  -----------
  Fix MSAN error: use of unitialized value when hashing the MLIR pass manager (NFC)

  Commit: a95298a0ed4b42dc79ebda2db1f8f371447c37db
      https://github.com/llvm/llvm-project/commit/a95298a0ed4b42dc79ebda2db1f8f371447c37db
  Author: Mehdi Amini <joker.eph at gmail.com>
  Date:   2023-08-25 (Fri, 25 Aug 2023)

  Changed paths:
    M mlir/include/mlir/IR/OpImplementation.h
    M mlir/lib/Transforms/Canonicalizer.cpp

  Log Message:
  -----------
  Fix canonicalizer to copy the entire GreedyRewriteConfig instead of selected fields

It is surprising for the user that only some fields were honored.

Also make the FrozenRewritePatternSet a shared_ptr<const T>.

Fixes #64543

Differential Revision: https://reviews.llvm.org/D157469

  Commit: 5e47fe1945952aa7719f1a139cdabd7b37cf6511
      https://github.com/llvm/llvm-project/commit/5e47fe1945952aa7719f1a139cdabd7b37cf6511
  Author: Mehdi Amini <joker.eph at gmail.com>
  Date:   2023-08-25 (Fri, 25 Aug 2023)

  Changed paths:
    M mlir/test/lib/Dialect/Test/TestOps.td
    M mlir/tools/mlir-tblgen/OpDefinitionsGen.cpp

  Log Message:
  -----------
  Fix ODS verifier emission for DerivedAttr when Properties are enabled

Differential Revision: https://reviews.llvm.org/D158679

Compare: https://github.com/llvm/llvm-project/compare/e54f48384bb2...5e47fe194595