[all-commits] [llvm/llvm-project] b5ac16: [BOLT] Give precedence to first AddressMap entries

Rafael Auler via All-commits all-commits at lists.llvm.org
Thu Aug 24 12:00:12 PDT 2023

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: b5ac1697c88bda324111f1fb61c93e091cefe500
  Author: Rafael Auler <rafaelauler at fb.com>
  Date:   2023-08-24 (Thu, 24 Aug 2023)

  Changed paths:
    M bolt/lib/Core/AddressMap.cpp

  Log Message:
  [BOLT] Give precedence to first AddressMap entries

When parsing AddressMap and there is a conflict in keys,
where two entries share the same key, consider the first entry as the
correct one, instead of the last. This matches previous behavior in
BOLT and covers case such as BOLT creating a new basic block but
sharing the same input offset of the previous (or entry) basic
block. In this case, instead of translating debuginfo to use the newly
created BB, translate using the BB that was originally read from
input. This will increase our chances of getting debuginfo right.

Tested via binary comparison in tests:

Reviewed By: #bolt, maksfb, jobnoorman

Differential Revision: https://reviews.llvm.org/D158686

More information about the All-commits mailing list