[all-commits] [llvm/llvm-project] 167db7: [InstCombine] Guard against FP min/max in select f...

Nikita Popov via All-commits all-commits at lists.llvm.org
Thu Aug 24 06:33:36 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 167db7ce551b2c99fda6427449fb4361eade58bb
      https://github.com/llvm/llvm-project/commit/167db7ce551b2c99fda6427449fb4361eade58bb
  Author: Nikita Popov <npopov at redhat.com>
  Date:   2023-08-24 (Thu, 24 Aug 2023)

  Changed paths:
    M llvm/lib/Transforms/InstCombine/InstructionCombining.cpp
    M llvm/test/Transforms/InstCombine/minmax-fp.ll

  Log Message:
  -----------
  [InstCombine] Guard against FP min/max in select fold (PR64937)

This is partial revert of cbca9ce91c6440f8815742b8a73a27aa81e806e6.
That commit removed the code guarding against min/max SPF patterns,
because those are now canonicalized to min/max intrinsics. However,
this is only true for integer min/max, while FP min/max can not
always be canonicalized to an intrinsic. As such, restore a
simplified version of the guard that handles only the FP case.

Fixes https://github.com/llvm/llvm-project/issues/64937.




More information about the All-commits mailing list