[all-commits] [llvm/llvm-project] 0d9919: Revert "[Clang] CWG1473: do not err on the lack of...

[Reid Kleckner via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 0d9919d362a7a70b2a7970861d897ecc47ec9e4d
      https://github.com/llvm/llvm-project/commit/0d9919d362a7a70b2a7970861d897ecc47ec9e4d
  Author: Reid Kleckner <rnk at google.com>
  Date:   2023-08-22 (Tue, 22 Aug 2023)

  Changed paths:
    M clang/docs/ReleaseNotes.rst
    M clang/include/clang/Basic/DiagnosticLexKinds.td
    M clang/include/clang/Basic/DiagnosticSemaKinds.td
    M clang/lib/Lex/Lexer.cpp
    M clang/test/CXX/drs/dr14xx.cpp
    M clang/test/CXX/drs/dr17xx.cpp
    M clang/test/CXX/drs/dr25xx.cpp
    M clang/test/CXX/lex/lex.literal/lex.ext/p1.cpp
    M clang/test/CXX/lex/lex.literal/lex.ext/p10.cpp
    M clang/test/CXX/lex/lex.literal/lex.ext/p11.cpp
    M clang/test/CXX/lex/lex.literal/lex.ext/p3.cpp
    M clang/test/CXX/lex/lex.literal/lex.ext/p4.cpp
    M clang/test/CXX/lex/lex.literal/lex.ext/p5.cpp
    M clang/test/CXX/lex/lex.literal/lex.ext/p6.cpp
    M clang/test/CXX/lex/lex.literal/lex.ext/p7.cpp
    M clang/test/CXX/lex/lex.literal/lex.ext/p8.cpp
    M clang/test/CXX/lex/lex.literal/lex.ext/p9.cpp
    M clang/test/CXX/over/over.oper/over.literal/p2.cpp
    M clang/test/CXX/over/over.oper/over.literal/p3.cpp
    M clang/test/CXX/over/over.oper/over.literal/p5.cpp
    M clang/test/CXX/over/over.oper/over.literal/p6.cpp
    M clang/test/CXX/over/over.oper/over.literal/p7.cpp
    M clang/test/CXX/over/over.oper/over.literal/p8.cpp
    M clang/test/CodeGenCXX/cxx11-user-defined-literal.cpp
    M clang/test/CodeGenCXX/mangle-ms-cxx11.cpp
    M clang/test/FixIt/fixit-c++11.cpp
    M clang/test/OpenMP/amdgcn_ldbl_check.cpp
    M clang/test/PCH/cxx11-user-defined-literals.cpp
    M clang/test/Parser/cxx0x-literal-operators.cpp
    M clang/test/Parser/cxx11-user-defined-literals.cpp
    M clang/test/SemaCXX/cxx11-ast-print.cpp
    M clang/test/SemaCXX/cxx11-user-defined-literals-unused.cpp
    M clang/test/SemaCXX/cxx11-user-defined-literals.cpp
    M clang/test/SemaCXX/cxx1y-user-defined-literals.cpp
    M clang/test/SemaCXX/cxx1z-user-defined-literals.cpp
    M clang/test/SemaCXX/cxx2a-consteval.cpp
    M clang/test/SemaCXX/cxx98-compat.cpp
    M clang/test/SemaCXX/literal-operators.cpp
    M clang/test/SemaCXX/no-warn-user-defined-literals-in-system-headers.cpp
    M clang/test/SemaCXX/reserved-identifier.cpp
    M clang/test/SemaCXX/warn-xor-as-pow.cpp
    M clang/www/cxx_dr_status.html

  Log Message:
  -----------
  Revert "[Clang] CWG1473: do not err on the lack of space after operator"""

This reverts commit f2583f3acf596cc545c8c0e3cb28e712f4ebf21b.

There is a large body of non-conforming C-like code using format strings
like this:

  #define PRIuS "zu"
  void h(size_t foo, size_t bar) {
    printf("foo is %"PRIuS", bar is %"PRIuS, foo, bar);
  }

Rejecting this code would be very disruptive. We could decide to do
that, but it's sufficiently disruptive that I think it requires
gathering more community consensus with an RFC, and Aaron indicated [1]
it's OK to revert for now so continuous testing systems can see past
this issue while we decide what to do.

[1] https://reviews.llvm.org/D153156#4607717