[all-commits] [llvm/llvm-project] 7822e5: [LLDB] Allow expression evaluators to set arbitrar...

[Walter Erquinigo via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 7822e5dbf1cb4be2d73eb13da27b04de684c318b
      https://github.com/llvm/llvm-project/commit/7822e5dbf1cb4be2d73eb13da27b04de684c318b
  Author: walter erquinigo <walter at modular.com>
  Date:   2023-08-22 (Tue, 22 Aug 2023)

  Changed paths:
    M lldb/include/lldb/Target/Target.h
    M lldb/test/API/commands/expression/ir-interpreter/TestIRInterpreter.py

  Log Message:
  -----------
  [LLDB] Allow expression evaluators to set arbitrary timeouts

https://github.com/llvm/llvm-project/commit/59237bb52c9483fce395428bfab5996eabe54ed0 changed the behavior of the `SetTimeout` and `GetTimeout` methods of `EvaluateExpressionOptions`, which broke the Mojo REPL and related services (https://docs.modular.com/mojo/) because it relies on having infinite timeouts. That's a necessity because developers often use the REPL for executing extremely long-running numeric jobs. Having said that, `EvaluateExpressionOptions` shouldn't be that opinionated on this matter anyway. Instead, it should be the responsibility of the evaluator to define which timeout to use for each specific case.

Differential Revision: https://reviews.llvm.org/D157764