[all-commits] [llvm/llvm-project] cfe9a1: [AMDGPU] Rename 64BitDPP feature and fix the checks

Stanislav Mekhanoshin via All-commits all-commits at lists.llvm.org
Tue Aug 22 11:00:27 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: cfe9a134bb1dda837786bbcca1b8f75f5c797175
      https://github.com/llvm/llvm-project/commit/cfe9a134bb1dda837786bbcca1b8f75f5c797175
  Author: Stanislav Mekhanoshin <Stanislav.Mekhanoshin at amd.com>
  Date:   2023-08-22 (Tue, 22 Aug 2023)

  Changed paths:
    M llvm/lib/Target/AMDGPU/AMDGPU.td
    M llvm/lib/Target/AMDGPU/AsmParser/AMDGPUAsmParser.cpp
    M llvm/lib/Target/AMDGPU/GCNDPPCombine.cpp
    M llvm/lib/Target/AMDGPU/GCNSubtarget.h
    M llvm/lib/Target/AMDGPU/MCTargetDesc/AMDGPUInstPrinter.cpp
    M llvm/lib/Target/AMDGPU/SIInstrInfo.cpp
    M llvm/lib/Target/AMDGPU/Utils/AMDGPUBaseInfo.cpp
    M llvm/lib/Target/AMDGPU/Utils/AMDGPUBaseInfo.h
    M llvm/lib/Target/AMDGPU/VOPInstructions.td
    M llvm/test/MC/AMDGPU/gfx90a_err.s
    M llvm/test/MC/AMDGPU/gfx940_asm_features.s
    M llvm/test/MC/AMDGPU/gfx940_err.s
    M llvm/test/MC/Disassembler/AMDGPU/gfx940_features.txt

  Log Message:
  -----------
  [AMDGPU] Rename 64BitDPP feature and fix the checks

Names '64BitDPP' and especially 'DPP64' were found misleading, and
DPP64 can easily be mixed with DPP16 and DPP8 while these are
different concepts. DPP16 and DPP8 refers to lanes where DPP64
refers to the operand size.

In fact the essential part here is that these instructions are
executed on the DP ALU, so rename the feature accordingly.

I have also found a bug in a check for these instructions, which is
fixed here and a common utility function is now used.

Differential Revision: https://reviews.llvm.org/D158465




More information about the All-commits mailing list