[all-commits] [llvm/llvm-project] 57f0bd: [OpenMP][OMPT] Fix `target enter data` callback or...

Michael Halkenhäuser via All-commits all-commits at lists.llvm.org
Tue Aug 22 10:12:42 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 57f0bdc8fb1e66d4ed9cfb57f1ef699eefd99646
      https://github.com/llvm/llvm-project/commit/57f0bdc8fb1e66d4ed9cfb57f1ef699eefd99646
  Author: Michael Halkenhaeuser <MichaelGerald.Halkenhauser at amd.com>
  Date:   2023-08-22 (Tue, 22 Aug 2023)

  Changed paths:
    M openmp/libomptarget/src/interface.cpp
    A openmp/libomptarget/test/ompt/veccopy_data.c

  Log Message:
  -----------
  [OpenMP][OMPT] Fix `target enter data` callback ordering & reported device num

This patch fixes: https://github.com/llvm/llvm-project/issues/64738
We observed multiple issues, primarily that the `DeviceId` was reported as -1
in certain scenarios. The reason for this is simply that the device is not
initialized at that point. Hence, we need to move the RAII object creation just
after the `checkDeviceAndCtors`, closer to the actual call we want to observe.

This also solves an odering issue where one `target enter data` callback would
be executed before the `Init` callback.
Additionally, this change will also fix that the callbacks corresponding to
`enter / exit data` and `update` in conjunction with `nowait` would not result
in the emission of an OMPT callback.

Added a testcase to cover initialized device number and `omp target` constructs.

Reviewed By: dhruvachak

Differential Revision: https://reviews.llvm.org/D157605




More information about the All-commits mailing list