[all-commits] [llvm/llvm-project] 991885: [RISCV] Remove fixed length lmul max restriction f...

[Luke Lau via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 9918853215d61ecb2744e87b802962340b6ae1d2
      https://github.com/llvm/llvm-project/commit/9918853215d61ecb2744e87b802962340b6ae1d2
  Author: Luke Lau <luke at igalia.com>
  Date:   2023-08-22 (Tue, 22 Aug 2023)

  Changed paths:
    M llvm/test/CodeGen/RISCV/rvv/fixed-vectors-int-buildvec.ll

  Log Message:
  -----------
  [RISCV] Remove fixed length lmul max restriction from build_vector tests. NFC

I'm not sure why the flag was added initially but I find the tests a bit easier
to read with it off, and it matches the default behaviour.

Reviewed By: craig.topper, reames

Differential Revision: https://reviews.llvm.org/D157973


  Commit: 7492b54bd52d10ca1e02693c2576cb19ec7233ed
      https://github.com/llvm/llvm-project/commit/7492b54bd52d10ca1e02693c2576cb19ec7233ed
  Author: Luke Lau <luke at igalia.com>
  Date:   2023-08-22 (Tue, 22 Aug 2023)

  Changed paths:
    M llvm/test/CodeGen/RISCV/rvv/fixed-vectors-int-buildvec.ll

  Log Message:
  -----------
  [RISCV] Split up structs in buildvec tests. NFC

Some of these tests have multiple vid sequence build_vectors in them, and machine CSE tidies up their output.
But now that small build_vectors are sometimes lowered to scalar `vmv.x.s`s, the output is harder to read with no CSE, e.g. see `buildvec_no_vid_v4i8`.

This patch splits them up into separate functions to address this, and also makes the diff in D157976 more clear since it causes `vmv.x.s` to be lowered to more frequently.

Reviewed By: reames

Differential Revision: https://reviews.llvm.org/D157974


  Commit: 4f996d7fbf293300556e537d596187c5a70d8627
      https://github.com/llvm/llvm-project/commit/4f996d7fbf293300556e537d596187c5a70d8627
  Author: Luke Lau <luke at igalia.com>
  Date:   2023-08-22 (Tue, 22 Aug 2023)

  Changed paths:
    M llvm/test/CodeGen/RISCV/rvv/fixed-vectors-int-buildvec.ll

  Log Message:
  -----------
  [RISCV] Add test for constant build_vector that could use vid. NFC

We currently don't lower this to a vid because the addend doesn't fit into a
vadd.vi immediate. An extra li here seems like a small cost to pay for a
constant pool load.

Reviewed By: reames

Differential Revision: https://reviews.llvm.org/D157975


  Commit: 946c672fe0b4e87cf56dcc694896df8626c2e2a6
      https://github.com/llvm/llvm-project/commit/946c672fe0b4e87cf56dcc694896df8626c2e2a6
  Author: Luke Lau <luke at igalia.com>
  Date:   2023-08-22 (Tue, 22 Aug 2023)

  Changed paths:
    M llvm/test/CodeGen/RISCV/rvv/fixed-vectors-fp-buildvec.ll

  Log Message:
  -----------
  [RISCV] Remove fixed length lmul max restriction from fp build_vector tests. NFC

For the same reasons as D157973, remove the LMUL flag from the tests to
simplify them and make the diffs in D157976 easier to read.

Reviewed By: craig.topper

Differential Revision: https://reviews.llvm.org/D158270


Compare: https://github.com/llvm/llvm-project/compare/acc5db2bedd5...946c672fe0b4