[all-commits] [llvm/llvm-project] 23459f: [Lex] Preambles should contain the global module f...

Sam McCall via All-commits all-commits at lists.llvm.org
Tue Aug 22 02:56:09 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 23459f13fcd9c424a41debb2d11eb56843d4e679
      https://github.com/llvm/llvm-project/commit/23459f13fcd9c424a41debb2d11eb56843d4e679
  Author: Sam McCall <sam.mccall at gmail.com>
  Date:   2023-08-22 (Tue, 22 Aug 2023)

  Changed paths:
    M clang-tools-extra/clangd/unittests/ModulesTests.cpp
    M clang/lib/Lex/Lexer.cpp
    M clang/unittests/Lex/CMakeLists.txt
    M clang/unittests/Lex/LexerTest.cpp

  Log Message:
  -----------
  [Lex] Preambles should contain the global module fragment.

For applications like clangd, the preamble remains an important optimization
when editing a module definition. The global module fragment is a good fit for
it as it by definition contains only preprocessor directives.
Before this patch, we would terminate the preamble immediately at the "module"
keyword.

Differential Revision: https://reviews.llvm.org/D158439




More information about the All-commits mailing list