[all-commits] [llvm/llvm-project] d2f2ef: [MLIR][Linalg] Respect DPS in `lower_unpack`

lorenzo chelini via All-commits all-commits at lists.llvm.org
Tue Aug 22 00:39:02 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: d2f2ef84e82f2fa4cc47fabbb2d7a0ab011a654d
      https://github.com/llvm/llvm-project/commit/d2f2ef84e82f2fa4cc47fabbb2d7a0ab011a654d
  Author: Lorenzo Chelini <l.chelini at icloud.com>
  Date:   2023-08-22 (Tue, 22 Aug 2023)

  Changed paths:
    M mlir/lib/Dialect/Linalg/Transforms/Transforms.cpp
    M mlir/test/Dialect/Linalg/transform-lower-pack.mlir

  Log Message:
  -----------
  [MLIR][Linalg] Respect DPS in `lower_unpack`

`tensor.unpack` implements the DPS (Destination Passing Style) interface
and expects the result to be "stored" in the `outs` operand, but this is
not the case with the current decomposition as the final operation is a
`tensor.extract_slice` that does not implement DPS. Add a `linalg.copy`
to fix the problem.

Reviewed By: springerm

Differential Revision: https://reviews.llvm.org/D158393




More information about the All-commits mailing list