[all-commits] [llvm/llvm-project] 1094e2: [TextAPI] Make sortTargetValues strict weak orderi...

Cyndy Ishida via All-commits all-commits at lists.llvm.org
Mon Aug 21 08:57:33 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 1094e2ebbae6a9ba540b9fd84ea434eff8c3676f
      https://github.com/llvm/llvm-project/commit/1094e2ebbae6a9ba540b9fd84ea434eff8c3676f
  Author: Danila Kutenin <kudanila at yandex.ru>
  Date:   2023-08-21 (Mon, 21 Aug 2023)

  Changed paths:
    M llvm/tools/llvm-readtapi/DiffEngine.cpp

  Log Message:
  -----------
  [TextAPI] Make sortTargetValues strict weak ordering compliant

Second sorting was not following strict weak ordering as it
does not follow transitivity of equivalence property.

If you build llvm with libcxx at head as a standard library with -D_LIBCPP_DEBUG_STRICT_WEAK_ORDERING_CHECK and -D_LIBCPP_ENABLE_DEBUG_MODE, then tests like llvm/test/tools/llvm-readtapi/compare-right-single-inline.test.test will fail

I don't have commit rights. Danila Kutenin kudanila at yandex.ru

Reviewed By: cishida

Differential Revision: https://reviews.llvm.org/D157958




More information about the All-commits mailing list