[all-commits] [llvm/llvm-project] 697092: [libc] Remove 'try_open' from the client interface

[Joseph Huber via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 6970920ca6ab318616a13df8967093de9dbedca2
      https://github.com/llvm/llvm-project/commit/6970920ca6ab318616a13df8967093de9dbedca2
  Author: Joseph Huber <jhuber6 at vols.utk.edu>
  Date:   2023-08-21 (Mon, 21 Aug 2023)

  Changed paths:
    M libc/src/__support/RPC/rpc.h

  Log Message:
  -----------
  [libc] Remove 'try_open' from the client interface

We previously provided the `try_open` facility to indicate if opening a
port failed. This is used on the server to continuously poll and quit if
there is no work. However the Client currently has no way to recover
from not finding a port and simply spins repeatedly. The abstraction
here costs us some resources. This patch changes the interface to only
allow `open` on the client side and merges the loops. This saves us a
branch and a good number of registers.

Reviewed By: JonChesterfield

Differential Revision: https://reviews.llvm.org/D158365