[all-commits] [llvm/llvm-project] ca1295: [DebugInfo] Alternate (more efficient) MD5 fix

Paul T Robinson via All-commits all-commits at lists.llvm.org
Thu Aug 17 07:04:05 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: ca1295c5a15f03ede2fe620cc80d6a1e6e6735b8
      https://github.com/llvm/llvm-project/commit/ca1295c5a15f03ede2fe620cc80d6a1e6e6735b8
  Author: Paul Robinson <paul.robinson at sony.com>
  Date:   2023-08-17 (Thu, 17 Aug 2023)

  Changed paths:
    M clang/lib/CodeGen/CGDebugInfo.cpp
    M clang/lib/CodeGen/CGDebugInfo.h
    M clang/test/CodeGenCXX/debug-info-function-context.cpp

  Log Message:
  -----------
  [DebugInfo] Alternate (more efficient) MD5 fix

D155991 changed the file lookup to do a full string compare on the
filename; however, this added ~0.5% to compile time with -g.
Go back to the previous pointer-based lookup, but capture the main
file's checksum as well as its name to use when creating the extra
DIFile entry. This causes all entries to be consistent and also
avoids computing the checksum twice.

Differential revision: https://reviews.llvm.org/D156571




More information about the All-commits mailing list