[all-commits] [llvm/llvm-project] 760261: [libc++] Fix a few incorrect CMake configuration o...

Louis Dionne via All-commits all-commits at lists.llvm.org
Thu Aug 17 06:43:42 PDT 2023

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 760261a3daf98882ccbd177e3133fb4a058f47ad
  Author: Louis Dionne <ldionne.2 at gmail.com>
  Date:   2023-08-17 (Thu, 17 Aug 2023)

  Changed paths:
    M libcxx/CMakeLists.txt
    M libcxxabi/CMakeLists.txt

  Log Message:
  [libc++] Fix a few incorrect CMake configuration options

This patch fixes a few CMake options that were set using incorrect

CMake's man page for the -D <var>=<value> option states: If a command in
the project sets the type to PATH or FILEPATH, then the <value> will be
converted to an absolute path. That's not what we want for most of the
paths we have as configuration options. Otherwise, using -D to set the
configuration option results in an absolute path being used, which
breaks things.

option() denotes a boolean variable, but what was desired was a
string/list variable. Fix this to prevent cmake from changing any
non-empty user provided values to 'ON'.

Differential Revision: https://reviews.llvm.org/D157926

More information about the All-commits mailing list