[all-commits] [llvm/llvm-project] bd7a4d: Restore "[LLVM] move verification of convergence c...

Sameer Sahasrabuddhe via All-commits all-commits at lists.llvm.org
Wed Aug 2 22:09:30 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: bd7a4d7b2736be3ed875f640be11395344e03315
      https://github.com/llvm/llvm-project/commit/bd7a4d7b2736be3ed875f640be11395344e03315
  Author: Sameer Sahasrabuddhe <sameer.sahasrabuddhe at amd.com>
  Date:   2023-08-03 (Thu, 03 Aug 2023)

  Changed paths:
    A llvm/include/llvm/ADT/GenericConvergenceVerifier.h
    M llvm/include/llvm/ADT/GenericSSAContext.h
    A llvm/include/llvm/IR/ConvergenceVerifier.h
    A llvm/include/llvm/IR/GenericConvergenceVerifierImpl.h
    M llvm/lib/CodeGen/MachineSSAContext.cpp
    M llvm/lib/IR/CMakeLists.txt
    A llvm/lib/IR/ConvergenceVerifier.cpp
    M llvm/lib/IR/SSAContext.cpp
    M llvm/lib/IR/Verifier.cpp
    M llvm/test/Verifier/convergencectrl-invalid.ll

  Log Message:
  -----------
  Restore "[LLVM] move verification of convergence control to a class template""

The refactored template can now be used with MachineVerifier.

Resubmitted after fixing build errors:

- Shared libraries build failed with undefined references due to "extern
  template" declarations.
- Modules build failed due to a cycle dependence between llvm/ADT and llvm/IR.
  The Generic*Impl.h files should be in llvm/IR to prevent this.

Differential Revision: https://reviews.llvm.org/D156522

This restores commit 93a3706711fd46d4d487640d91b16c2eec747c9e.
Originally reverted in 466bd9981150906552a1f2308e3c9065bfcb6741.




More information about the All-commits mailing list