[all-commits] [llvm/llvm-project] b1193c: [clangd] Avoid unexpected desugaring in isSugaredT...

zyn0217 via All-commits all-commits at lists.llvm.org
Tue Aug 1 05:12:53 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: b1193c13a5f9e9a2dca6ae0dd8b4e911f54c09ce
      https://github.com/llvm/llvm-project/commit/b1193c13a5f9e9a2dca6ae0dd8b4e911f54c09ce
  Author: Younan Zhang <zyn7109 at gmail.com>
  Date:   2023-08-01 (Tue, 01 Aug 2023)

  Changed paths:
    M clang-tools-extra/clangd/InlayHints.cpp
    M clang-tools-extra/clangd/unittests/InlayHintTests.cpp

  Log Message:
  -----------
  [clangd] Avoid unexpected desugaring in isSugaredTemplateParameter

This is a follow-up to D151785, addressing https://github.com/clangd/clangd/issues/1703.

The previous approach of peeling pointer types during a traversal
using getPointeeType might have produced unexpected results; since
the method would implicitly desugar the type if the type being passed
in could not be cast to a Pointer-like Type.

Reviewed By: nridge

Differential Revision: https://reviews.llvm.org/D156300




More information about the All-commits mailing list