[all-commits] [llvm/llvm-project] cd921e: [MISched] Do not erase resource booking history fo...

Francesco Petrogalli via All-commits all-commits at lists.llvm.org
Tue Aug 1 05:01:24 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: cd921e0fd79cd9bd2ab2ee1820476810847f5516
      https://github.com/llvm/llvm-project/commit/cd921e0fd79cd9bd2ab2ee1820476810847f5516
  Author: Francesco Petrogalli <francesco.petrogalli at apple.com>
  Date:   2023-08-01 (Tue, 01 Aug 2023)

  Changed paths:
    M llvm/lib/CodeGen/MachineScheduler.cpp
    A llvm/test/CodeGen/ARM/misched-prevent-erase-history-of-subunits.mir

  Log Message:
  -----------
  [MISched] Do not erase resource booking history for subunits.

When dealing with the subunits of a resource group, we should reset
the subunits availability at the first avaiable cycle of the resource
that contains the subunits. Previously, the reset operation was
returning cycle 0, effectively erasing the booking history of the
subunits.

Without this change, when using intervals for models have make use of
subunits, the erasing of resource booking for subunits can raise the
assertion "A resource is being overwritten" in
`ResourceSegments::add`. The test added in the patch is one of such
cases.

Reviewed By: andreadb

Differential Revision: https://reviews.llvm.org/D156530




More information about the All-commits mailing list