[all-commits] [llvm/llvm-project] b3c005: [JITLink] Don't try to abandon non-existent alloca...

lhames via All-commits all-commits at lists.llvm.org
Thu Jul 27 16:37:18 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: b3c0055c172be9ed4115cf894306a2016c8857bd
      https://github.com/llvm/llvm-project/commit/b3c0055c172be9ed4115cf894306a2016c8857bd
  Author: Lang Hames <lhames at gmail.com>
  Date:   2023-07-27 (Thu, 27 Jul 2023)

  Changed paths:
    M llvm/lib/ExecutionEngine/JITLink/JITLinkGeneric.cpp
    M llvm/unittests/ExecutionEngine/JITLink/CMakeLists.txt
    A llvm/unittests/ExecutionEngine/JITLink/JITLinkMocks.cpp
    A llvm/unittests/ExecutionEngine/JITLink/JITLinkMocks.h
    A llvm/unittests/ExecutionEngine/JITLink/MemoryManagerErrorTests.cpp

  Log Message:
  -----------
  [JITLink] Don't try to abandon non-existent allocations.

If JITLinkGeneric::linkPhase2 receives an Error rather than an InFlightAlloc
then we need to call JITLinkContext::notifyFailed, rather than calling
abandonAllocAndBailOut -- the latter asserts that there is an allocation to
abandon, and this was turning allocation errors into assertion failures in
debug mode.




More information about the All-commits mailing list