[all-commits] [llvm/llvm-project] 20280e: [RISCV] Fix predicates on zvbb patterns

Luke Lau via All-commits all-commits at lists.llvm.org
Mon Jul 17 01:18:14 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 20280ea44a36bdd5768349c263783240a0a36caa
      https://github.com/llvm/llvm-project/commit/20280ea44a36bdd5768349c263783240a0a36caa
  Author: Luke Lau <luke at igalia.com>
  Date:   2023-07-17 (Mon, 17 Jul 2023)

  Changed paths:
    M llvm/lib/Target/RISCV/RISCVInstrInfoZvk.td

  Log Message:
  -----------
  [RISCV] Fix predicates on zvbb patterns

The zvbb extension predicate was getting overwritten by the vtype predicates.
There's no change in the tests though because the ISD nodes were getting
expanded before instruction selection.

Reviewed By: craig.topper

Differential Revision: https://reviews.llvm.org/D155313


  Commit: b5bcd4f60ba3cbed05459e11d176a3f194145732
      https://github.com/llvm/llvm-project/commit/b5bcd4f60ba3cbed05459e11d176a3f194145732
  Author: Luke Lau <luke at igalia.com>
  Date:   2023-07-17 (Mon, 17 Jul 2023)

  Changed paths:
    M llvm/lib/Target/RISCV/RISCVISelLowering.cpp
    M llvm/lib/Target/RISCV/RISCVISelLowering.h
    M llvm/lib/Target/RISCV/RISCVInstrInfoVVLPatterns.td
    M llvm/lib/Target/RISCV/RISCVInstrInfoZvk.td
    M llvm/test/CodeGen/RISCV/rvv/bitreverse-vp.ll
    M llvm/test/CodeGen/RISCV/rvv/bswap-vp.ll
    M llvm/test/CodeGen/RISCV/rvv/ctlz-vp.ll
    M llvm/test/CodeGen/RISCV/rvv/ctpop-vp.ll
    M llvm/test/CodeGen/RISCV/rvv/cttz-vp.ll

  Log Message:
  -----------
  [RISCV] Add VL nodes and VP patterns for unary zvbb instructions

This follows the pattern of lowering VP nodes to equivalent
RISCVISD::*_VL nodes. The nodes are modelled after the VP ISD nodes rather
than the actual zvbb instructions, and I've included a merge operand to be
consistent with the underlying pseudos that were recently refactored.

I've defined the nodes in RISCVInstrInfoVVLpatterns.td as the nodes aren't Zvk
specific, but the patterns are in RISCVInstrInfoZvk.td.

Reviewed By: craig.topper

Differential Revision: https://reviews.llvm.org/D155229


Compare: https://github.com/llvm/llvm-project/compare/0ebb0503113e...b5bcd4f60ba3


More information about the All-commits mailing list