[all-commits] [llvm/llvm-project] 199034: [ORC] In defineMaterializing, error out early if t...

lhames via All-commits all-commits at lists.llvm.org
Sun Jul 16 17:38:48 PDT 2023

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 199034e8acd602d5a2475d537ae8265c4e3ee5a7
  Author: Lang Hames <lhames at gmail.com>
  Date:   2023-07-16 (Sun, 16 Jul 2023)

  Changed paths:
    M llvm/include/llvm/ExecutionEngine/Orc/Core.h
    M llvm/lib/ExecutionEngine/Orc/Core.cpp
    M llvm/unittests/ExecutionEngine/Orc/CoreAPIsTest.cpp

  Log Message:
  [ORC] In defineMaterializing, error out early if tracker is defunct.

An in-flight materialization may try to claim responsibility for new symbols
(via MaterializationResponsibility::defineMaterializing) after the tracker that
is associated with the materialization is removed, leaving the tracker defunct.

Failure to error out early here could leave the JITDylib in an invalid state,
with defineMaterializing associating new symbols with the already-defunct
tracker. Erroring out early prevents this.

More information about the All-commits mailing list