[all-commits] [llvm/llvm-project] 2a33f4: [RISCV] Make selectSETCC return SDValue instead of...

[Craig Topper via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 2a33f479120e4b495a2356ac6fe3181776e3c880
      https://github.com/llvm/llvm-project/commit/2a33f479120e4b495a2356ac6fe3181776e3c880
  Author: Craig Topper <craig.topper at sifive.com>
  Date:   2023-07-16 (Sun, 16 Jul 2023)

  Changed paths:
    M llvm/lib/Target/RISCV/RISCVISelLowering.cpp

  Log Message:
  -----------
  [RISCV] Make selectSETCC return SDValue instead of bool. NFC

We can use a null SDValue for the 'false' case. This avoids the
need for an output parameter. This is consistent with other
SelectionDAG code.

Reviewed By: wangpc

Differential Revision: https://reviews.llvm.org/D155388


  Commit: ce7057830345907fe986925a9e5913f120acfab6
      https://github.com/llvm/llvm-project/commit/ce7057830345907fe986925a9e5913f120acfab6
  Author: Craig Topper <craig.topper at sifive.com>
  Date:   2023-07-16 (Sun, 16 Jul 2023)

  Changed paths:
    M llvm/lib/Target/RISCV/RISCVISelLowering.cpp

  Log Message:
  -----------
  [RISCV] Move comments before 'if' instead of after. NFC

This allows us to remove some curly braces around the if body.
The code wasn't consistent about it anyway. Comments before is
used in other places in this file already.

Reviewed By: wangpc, MaskRay

Differential Revision: https://reviews.llvm.org/D155390


Compare: https://github.com/llvm/llvm-project/compare/cc4f86562127...ce7057830345