[all-commits] [llvm/llvm-project] 56ae35: [NFC][libc++][bitset] Refactors constructors.

Mark de Wever via All-commits all-commits at lists.llvm.org
Sat Jul 15 06:21:48 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 56ae3568ead3beea5629ad20695f38d1e5ef26dc
      https://github.com/llvm/llvm-project/commit/56ae3568ead3beea5629ad20695f38d1e5ef26dc
  Author: Mark de Wever <koraq at xs4all.nl>
  Date:   2023-07-15 (Sat, 15 Jul 2023)

  Changed paths:
    M libcxx/include/bitset
    M libcxx/test/libcxx/transitive_includes/cxx03.csv
    M libcxx/test/libcxx/transitive_includes/cxx11.csv
    M libcxx/test/libcxx/transitive_includes/cxx14.csv
    M libcxx/test/libcxx/transitive_includes/cxx17.csv
    M libcxx/test/libcxx/transitive_includes/cxx20.csv
    M libcxx/test/libcxx/transitive_includes/cxx23.csv
    M libcxx/test/libcxx/transitive_includes/cxx26.csv
    M libcxx/test/std/utilities/template.bitset/bitset.members/left_shift.pass.cpp

  Log Message:
  -----------
  [NFC][libc++][bitset] Refactors constructors.

Based on the review comments in D153201 this combines the string and
c-string constructors. The common constructor is using a string_view:
- it allows propagating the _Traits, which are required to be used for
  comparison.
- it avoids allocating
- libc++ supports it in C++03

Reviewed By: philnik, #libc, ldionne

Differential Revision: https://reviews.llvm.org/D154860




More information about the All-commits mailing list