[all-commits] [llvm/llvm-project] cf40fd: [mlir] Don't emit forward declaration for user def...

Hideto Ueno via All-commits all-commits at lists.llvm.org
Thu Jul 13 21:20:13 PDT 2023

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: cf40fde4ed5cb76549aad733b8f540f9dda1e719
  Author: Hideto Ueno <uenoku.tokotoko at gmail.com>
  Date:   2023-07-13 (Thu, 13 Jul 2023)

  Changed paths:
    M flang/include/flang/Optimizer/Dialect/FIRType.h
    M mlir/include/mlir/IR/BuiltinAttributes.h
    M mlir/include/mlir/IR/BuiltinTypes.h
    M mlir/tools/mlir-tblgen/AttrOrTypeDefGen.cpp

  Log Message:
  [mlir] Don't emit forward declaration for user defined storage classes

Currently DefGen::emitDecl always emits forward declarations of storage classes even for user define ones, which makes it difficult to use template class directly in ODS. This patch changes `DefGen` not to emit forward decl when `genStorageClass` is false.

Original discussion: https://discourse.llvm.org/t/use-template-classes-as-user-defined-storage-classes/72015

Reviewed By: mehdi_amini, rriddle

Differential Revision: https://reviews.llvm.org/D155225

More information about the All-commits mailing list