[all-commits] [llvm/llvm-project] 3ff3af: [lldb] Add missing StringExtras.h includes

Elliot Goodrich via All-commits all-commits at lists.llvm.org
Thu Jul 13 13:09:22 PDT 2023

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 3ff3af3086da5df10d3991914262cef724156977
  Author: Elliot Goodrich <elliotgoodrich at gmail.com>
  Date:   2023-07-13 (Thu, 13 Jul 2023)

  Changed paths:
    M lldb/unittests/Symbol/PostfixExpressionTest.cpp
    M lldb/unittests/SymbolFile/NativePDB/UdtRecordCompleterTests.cpp

  Log Message:
  [lldb] Add missing StringExtras.h includes

In preparation for removing the #include "llvm/ADT/StringExtras.h"
from the header to source file of llvm/Support/Error.h, first add in
all the missing includes that were previously included transitively
through this header.

This is fixing all files missed in b0abd4893fa1, 39d8e6e22cd1,
a11efd49266f, 5551657b310b, and 90bfe2df25e7.

Differential Revision: https://reviews.llvm.org/D155178

  Commit: 3900860b386aa666eb03738d81fdc13afd647925
  Author: Elliot Goodrich <elliotgoodrich at gmail.com>
  Date:   2023-07-13 (Thu, 13 Jul 2023)

  Changed paths:
    M llvm/include/llvm/Support/Error.h
    M llvm/lib/Support/Error.cpp

  Log Message:
  [Support] Move StringExtras.h include from Error.h to Error.cpp

Move the implementation of the `toString` function from
`llvm/Support/Error.h` to the source file, which allows us to move
`#include "llvm/ADT/StringExtras.h"` to the source file as well.

As `Error.h` is present in a large number of translation units this
means we are unnecessarily bringing in the contents of
`StringExtras.h` - itself a large file with lots of includes - and
slowing down compilation.

Also move the `#include "llvm/ADT/SmallVector.h"` directive to the
source file as it's no longer needed, but this does not give as much of
a benefit.

This reduces the total number of preprocessing tokens across the LLVM
source files in lib from (roughly) 1,920,413,050 to 1,903,629,230 - a
reduction of ~0.87%. This should result in a small improvement in
compilation time.

Differential Revision: https://reviews.llvm.org/D155178

Compare: https://github.com/llvm/llvm-project/compare/7972b9c82996...3900860b386a

More information about the All-commits mailing list