[all-commits] [llvm/llvm-project] 8bb941: [Demangle] use std::string_view::data rather than ...

Nick Desaulniers via All-commits all-commits at lists.llvm.org
Thu Jul 13 10:20:35 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 8bb9414f1474d6a8caed2e7be5f1d3d999c8bae1
      https://github.com/llvm/llvm-project/commit/8bb9414f1474d6a8caed2e7be5f1d3d999c8bae1
  Author: Nick Desaulniers <ndesaulniers at google.com>
  Date:   2023-07-13 (Thu, 13 Jul 2023)

  Changed paths:
    M libcxxabi/src/demangle/ItaniumDemangle.h
    M llvm/include/llvm/Demangle/ItaniumDemangle.h
    M llvm/lib/Demangle/ItaniumDemangle.cpp
    M llvm/lib/Demangle/MicrosoftDemangle.cpp

  Log Message:
  -----------
  [Demangle] use std::string_view::data rather than &*std::string_view::begin

To fix expensive check builds that were failing when using MSVC's
std::string_view::iterator::operator*, I added a few expressions like
&*std::string_view::begin.  @nico pointed out that this is literally the
same thing and more clearly expressed as std::string_view::data.

Link: https://github.com/llvm/llvm-project/issues/63740

Reviewed By: #libc_abi, ldionne, philnik, MaskRay

Differential Revision: https://reviews.llvm.org/D154876




More information about the All-commits mailing list