[all-commits] [llvm/llvm-project] 636f77: [mlir][Arith] Make previous load-bearing assert in...

Krzysztof Drewniak via All-commits all-commits at lists.llvm.org
Thu Jul 13 07:49:43 PDT 2023

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 636f7728711450fe8a68c7a9b156caab39880a25
  Author: Krzysztof Drewniak <Krzysztof.Drewniak at amd.com>
  Date:   2023-07-13 (Thu, 13 Jul 2023)

  Changed paths:
    M mlir/lib/Dialect/Arith/Transforms/EmulateUnsupportedFloats.cpp

  Log Message:
  [mlir][Arith] Make previous load-bearing assert into a real error

When I landed the EmulateUnsupportedFloats, I'd negligently included
an assert that needed to run for the pass to be correct. Previous
emergency fix commits removed the assert. This commit re-adds the
"can't happen" testing as an emitOpError() and aborting the rewrite,
thus allowing it to function in no-assertions builds.

Reviewed By: kuhar

Differential Revision: https://reviews.llvm.org/D155088

More information about the All-commits mailing list