[all-commits] [llvm/llvm-project] 9418c4: [amdgpu][lds] Raise an explicit unimplemented erro...

Jon Chesterfield via All-commits all-commits at lists.llvm.org
Thu Jul 13 03:32:35 PDT 2023

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 9418c40af7ec6913112b82d6f1d6e8a8c43af6c0
  Author: Jon Chesterfield <jonathanchesterfield at gmail.com>
  Date:   2023-07-13 (Thu, 13 Jul 2023)

  Changed paths:
    M llvm/lib/Target/AMDGPU/AMDGPULowerModuleLDSPass.cpp
    A llvm/test/CodeGen/AMDGPU/lds-reject-absolute-addresses.ll

  Log Message:
  [amdgpu][lds] Raise an explicit unimplemented error on absolute address LDS variables

These aren't implemented. They could be at moderate implementation
complexity. Raising an error is better than silently miscompiling.

Patching now because the patch at D155125 is a step towards using this metadata
more extensively as part of the lowering path and that will interact badly with
input variables with this annotation.

Lowering user defined variables at specific addresses would drop this error,
put them at the requested position in the frame during this pass, and then
use the same codegen that will be used for the kernel specific struct shortly.

Reviewed By: jmmartinez

Differential Revision: https://reviews.llvm.org/D155132

More information about the All-commits mailing list